Evan/audio gain #213
Open
Evan/audio gain #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carloshmorales
requested changes
Dec 10, 2024
There was a problem hiding this comment.
These changes are approved, but please look at this fix in ns-mirror and make sure the same fix is in neuralspot: https://github.com/AmbiqAI/ns-mirror/commit/05aeb4de5b39fb50173fa5ac97ea5402d3587b50
There was a segfault case when set_gain was called after audio_init and before audio_start because pdm_config was null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds audio gain function for apollo4p and apollo4p_blue_kxr