-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Block
using a related "TranslatedContent" model
#1215
Comments
I agree with almost all of your choices. See also #1211 for your comment on enforcing a As for the one thing I'd change: I was actually wondering, what with the removal of the |
Requirements
BlockTranslatedContent
model with the following propertiesFK
toBlock
CharField
with thechoices=language_choices
name
&description
fields from theBlock
modelPhase
, i.e. don't allowblank=True
andnull=True
in theBlock
'sphase
field. (see NB) In the migration, we can create an empty experiment and phase for all blocks that are currently dangling without a phase and experiment.url
andhashtag
properties as these are configured inSocialMediaConfig
alreadylanguage
field fromBlock
since it will be rendered irrelevant by this feature. I'm not sure what extra work needs to be done for this.NB
index
- which does exist onExperimentTranslatedContent
won't be needed here as the fallback language is determined on the experiment level.Block
that is not related to aPhase
(which still seems to be possible currently) will probably result in a crash or by picking the first language content it finds. Should we enforce a relation to aPhase
eventually to avoid this problem? I think that was the plan anyway.image
, which might be considered to be in tandem withname
anddescription
has no textual content so it needs not to be translated. Right? Anyone, please let me know if you disagree.The text was updated successfully, but these errors were encountered: