Added: Add multi-languageBlockTranslatedContent in relation to Block
#1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ManyToMany relationship
…nstead of on `BlockTranslatedContent`
drikusroor
force-pushed
the
feat/1215-block-translated-content
branch
from
4a2ff99
to
e64223c
Compare
4 tasks
…esults into errors as the validator looks for translated content using the FKs
…ontent` relationship to `ForeignKey` - Update Block model to use ForeignKey for translated_contents - Modify migrations to reflect new relationship - Adjust admin interface to handle inline editing of translated contents - Update related queries and methods to use new relationship structure
BeritJanssen
reviewed
Sep 2, 2024
BeritJanssen
approved these changes
Sep 2, 2024
| @@ -112,29 +117,31 @@ class Block(models.Model): | |||
| phase = models.ForeignKey(Phase, on_delete=models.CASCADE, related_name="blocks", blank=True, null=True) | |||
| index = models.IntegerField(default=0, help_text="Index of the block in the phase. Lower numbers come first.") | |||
| playlists = models.ManyToManyField("section.Playlist", blank=True) | |||
|
|
|||
| # TODO: to be deleted? | |||
There was a problem hiding this comment.
After this has been moved to BlockTranslatedContent, I think we can remove these, indeed.
There was a problem hiding this comment.
I was wondering though: What will be the name of a Block that has no Translated Content? How should we display it in the form/list?
There was a problem hiding this comment.
Hmm, perhaps just the object name with id (which would be Django's default)?
There was a problem hiding this comment.
The __str__ method might also return something like Block with slug {slug} perhaps?
…des fix for the tabular inline form's heading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
BlockTranslatedContentmodel with an FK toBlockblock,language,name,descriptionBlock(like name & description) to aBlockTranslatedContentwith the same language as the block (or defaults to English)consent,hashtag,languageandurlfrom the `Block model.nameanddescriptionfor now as it might be convenient for the experiment administrator. They aren't used by anything afaikdjango-nested-adminwhose fix is not yet released.Video of experiment form
Screen.Recording.2024-08-30.at.12.29.26.mov