Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub Actions #19

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

MoshiBin
Copy link

@MoshiBin MoshiBin commented Apr 3, 2024

  • Linters currently includes only Ruff, but can be easily amended to add linters as needed (maybe mypy, markdown lint, etc).
  • Test performs a basic installation of the package and tries to run the CLI with --help. It may be extended in the future to run extra tests as needed. Note that this action currently fails because it tries to test Python 3.12, which requires Add niimprint command #18 to be merged. Edited to add support for Python 3.10+, including 3.12, no longer requires Add niimprint command #18.

.github/workflows/linters.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
@MoshiBin MoshiBin mentioned this pull request Apr 10, 2024
@MoshiBin
Copy link
Author

Added support & testing for Python 3.10 (which removes the dependency on #18), replaced the ruff action with pre-commit, added the todo notice for caching poetry venvs - I'll look into this later.

@MoshiBin MoshiBin requested a review from AndBondStyle April 10, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants