Remove deprecated typing and fix thread safety issue #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niekschoemaker
force-pushed
the
fix-state-write
branch
from
20f3bf6 to
6ffb7a4
Compare
|
Just pushed another two commits. I finally figured out what was causing the thread safety issues in the first place. However I'm not sure if the async_write_ha_state can be used at this point or not, and also don't see any issue with simply keeping it as schedule_update_ha_state. The latest fix resolves issues with the things like "Current Temperature" and the state of the machine not updating when changed from anything other than home assistant, since these were done through mqtt which runs a different event loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues with state updates, since newer home assistant versions async_write_ha_state gets blocked from other threads, so I replaced those calls with schedule_update_ha_state. And replaced the HomeAssistantType with HomeAssistant since HomeAssistantType is deprecated.
Also had some left overs from a while ago where I added the compressor frequency as a state which shows the load on the air conditioner currently.
I tested this running on my own Home Assistant setup with a few Haier Air Conditioners and this appears to fix the issues with the state not updating.