Merge pull request #293 from AndreaPontrandolfo/AndreaPontrandolfo/is…

…sue251 feature(rules): changed some rules for nextjs
AndreaPontrandolfo · Nov 1, 2024 · 90ef6e5 · 90ef6e5
2 parents 3bbcf7f + 187e43c
commit 90ef6e5
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 0 deletions.
diff --git a/.changeset/nice-walls-cheat.md b/.changeset/nice-walls-cheat.md
@@ -0,0 +1,6 @@
+---
+'eslint-config-sheriff': minor
+---
+
+feature(rules): changed some rules for nextjs
+Fixes #251
diff --git a/apps/config-validation-playground/src/mocks/InfoButton.tsx b/apps/config-validation-playground/src/mocks/InfoButton.tsx
@@ -1,3 +1,5 @@
+/* eslint-disable react/function-component-definition */
+
 import type { JSX } from 'react';
 
 interface InfoButtonProps {

diff --git a/apps/config-validation-playground/src/samples/react.tsx b/apps/config-validation-playground/src/samples/react.tsx
@@ -1,3 +1,5 @@
+/* eslint-disable react/function-component-definition */
+
 import type { JSX } from 'react';
 
 export const MyComponent = (): JSX.Element => {

diff --git a/packages/eslint-config-sheriff/src/nextjsConfig.ts b/packages/eslint-config-sheriff/src/nextjsConfig.ts
@@ -10,5 +10,14 @@ export const nextjsConfig = {
   rules: {
     ...nextjs.configs.recommended.rules,
     ...nextjs.configs['core-web-vitals'].rules,
+    'import/no-default-export': 0,
+    'react/function-component-definition': [
+      2,
+      {
+        namedComponents: 'function-declaration',
+        unnamedComponents: 'function-expression',
+      },
+    ],
+    '@next/next/no-html-link-for-pages': 0, // pages router is legacy at this point. We don't need to support this rule anymore.
   },
 };