Better bundles

[lishaduck]

I was trying to fix #268, which seems fixed, but noticed some improvements that could be made.

Resolves #288
Fixes #289
Relates to #193

[changeset-bot]

⚠️ No Changeset found

Latest commit: c738c5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sheriff	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2024 7:14pm

[AndreaPontrandolfo]

@lishaduck i'm pretty sure i had to remove attw because it was crashing on my Windows machine.

[lishaduck]

@lishaduck i'm pretty sure i had to remove attw because it was crashing on my Windows machine.

Huh. I'll take a look.

[lishaduck]

Ah, I see. It runs in pwsh, so I can't use interpolation like that. Cooking something up real quick.

[lishaduck]

Ugh. I was wrong that pwsh supports globs.¹

Footnotes

1. Except, of course that it does. But only on UNIX. ↩

[lishaduck]

I assume you have bash (from git or wsl) on your machine? 🤣

[AndreaPontrandolfo]

I assume you have bash (from git or wsl) on your machine? 🤣

Git Bash, exactly, haha.

[lishaduck]

I assume you have bash (from git or wsl) on your machine? 🤣

Git Bash, exactly, haha.

Ok, I wrapped the script in bash -c, so it'll work 🤣

[AndreaPontrandolfo]

@lishaduck uhm, apparently the windows build is failing

[lishaduck]

@lishaduck uhm, apparently the windows build is failing

Yeah, it looks like there's an issue with globs & git bash. I was debugging it, but commit + push + wait for ci is a pretty slow way of checking.

[lishaduck]

@AndreaPontrandolfo, it works again!

Apparently npm pack is package manager agnostic, and all those workarounds aren't needed anymore because they were just for npm bugs that've been fixed in more recent versions.