Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace declaration processed first. Issue 22 #23

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

jbrayfaithlife
Copy link
Contributor

If a namespace is declared after an attribute that uses that namespace, the namespace should still be correctly identified. This code change causes any namespace declarations to be processed before other attributes.

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • [/] I have read the CONTRIBUTING document
  • [/] My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [/] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • [/] I have added tests to cover my changes
  • [/] All new and existing tests passed

Description

This code change causes any namespace declaration attributes to be processed before the other attributes, so if they make use of said namespaces, the namespace will have been registered and will be properly identified.

If a namespace is declared after an attribute that uses that namespace,
the namespace should still be correctly identified. This code change
causes any namespace declarations to be processed before other
attributes.
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants