Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Add sample_design class and re-implement design_effect #42

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Conversation

fredjaya
Copy link
Collaborator

Part of #40

Adds two sample_design classes, fixed_design and variable_design to:

  • reduce the repetition of input parameters across functions
  • separate the logic of the sampling approaches
  • drop the function naming _random (to come)

Changes the design_effect implementation:

  • From functions to methods dispatched according to sample_design class - this removes the need for a separate function named with _random

Adds check_input2.R:

Added and updated tests and documentation for sample_design and `design_effect

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37%. Comparing base (7ab5a24) to head (0e43edf).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   89.58%   90.37%   +0.78%     
==========================================
  Files          12       14       +2     
  Lines         989     1018      +29     
==========================================
+ Hits          886      920      +34     
+ Misses        103       98       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredjaya fredjaya merged commit e32e69a into main Jun 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants