Fix single file uploads in multi-file forms #514
Conversation
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/514 |
pydanny
force-pushed
the
fix-1-file-uploads-multiple-files
branch
from
f2a1fc4
to
b997e18
Compare
|
Hey @jph00, here's a patch for multi-file uploads that comes with a test. |
fasthtml/core.py
Outdated
| @@ -191,6 +191,10 @@ async def _find_p(req, arg:str, p:Parameter): | |||
| if (res in (empty,None)) and p.default is empty: raise HTTPException(400, f"Missing required field: {arg}") | |||
| # If we have a default, return that if we have no value | |||
| if res in (empty,None): res = p.default | |||
| # if anno is a Generic Alias but res isn't an iterable then wrap in list | |||
| if isinstance(anno, GenericAlias): | |||
There was a problem hiding this comment.
I think there are parameterised generics that aren't lists? We should probably me more specific about what we're looking for.
There was a problem hiding this comment.
@jph00 The challenge is that for this error anno is a GenericAlias, which arguably is a bug in its own right. Or maybe we're just not particular enough so this is a missing feature? Looking into that now.
In the meantime, I've changed the try/except to a more precise check. Hopefully that goes away, replaced with a more accurate anno specification.
There was a problem hiding this comment.
Diving into Fastcore's signature_ex function.
There was a problem hiding this comment.
Hmmm... I think signature_ex is a tangent. Digging into the behavior around params in _wrap_req.
Co-Authored-By: Audrey M. Roy Greenfeld <[email protected]>
pydanny
force-pushed
the
fix-1-file-uploads-multiple-files
branch
from
b997e18
to
e254e80
Compare
name: Pull Request
about: Propose changes to the codebase
title: '[PR] Fix single file uploads in multi-file forms'
labels: 'bug'
assignees: ''
Related Issue
#513 Uploading a single file on a multiple file field requires a try/except block
Proposed Changes
If the annotation for the response element says it is a
GenericAlias(which roughly means 'iterable') but the response element isn't actually iterable, then wrap it in a list.Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply:Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.