fix(raw): replace NaN values by 'NaN' inside output matrices #2278
+156
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some output matrices have NaN values. Currently we try to replace them by None but it does nothing (output_series_matrix file) and we serialize NaN values as NaN (with pydanitic type adapter). But JavaScript cannot seems to parse the JSON and so the front-end has to do some post-processing to display those matrices. This PR replaces the NaN by "NaN" for the JSON to be JavaScript parsable. It works well but we're not too sure we should do it so I'll mark this PR as draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.