Refactor link series #1721
Merged
Refactor link series #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-zakir
reviewed
Oct 31, 2023
sylvlecl
previously requested changes
Nov 3, 2023
flomnes
reviewed
Nov 6, 2023
flomnes
requested changes
Nov 13, 2023
Comment on lines
566
to
567
| ntc.ValeurDeNTCOrigineVersExtremite[k] = lnk.directCapacities.getCoefficient(year, hourInYear); | ||
| ntc.ValeurDeNTCExtremiteVersOrigine[k] = lnk.indirectCapacities.getCoefficient(year, hourInYear); |
There was a problem hiding this comment.
Performance improvement :
- swap loops on links & hours
- use
TimeSeries::getColumna single time instead ofTimeSeries::getCoefficient8700 times
You could do it here, or open a ticket to fix the issue elsewhere as well (I noticed it here and there)
@payetvin what do you think ?
|
Kudos, SonarCloud Quality Gate passed! |
flomnes
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1669