Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High-level API: provide output path instead of returning it [ANT-2561] #2548

Merged
merged 8 commits into from
Jan 3, 2025

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Dec 20, 2024

TODO

  • Fix build for api_client_test (missing argument)
  • Fix extra output directory created by Simulator, for example 20241204-1554eco and 20241204-1554eco-2

@flomnes flomnes marked this pull request as draft December 20, 2024 16:31
@JasonMarechal25 JasonMarechal25 merged commit 9a9715e into develop Jan 3, 2025
10 checks passed
@JasonMarechal25 JasonMarechal25 deleted the fix/api-provide-output-path branch January 3, 2025 08:43
tbittar added a commit to AntaresSimulatorTeam/antares-xpansion that referenced this pull request Jan 6, 2025
### NOTE
This PR depends on
AntaresSimulatorTeam/Antares_Simulator#2548
because the signature of some functions were changed (output directory
becomes a return value).

---------

Co-authored-by: Jason Marechal <[email protected]>
Co-authored-by: Thomas Bittar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants