Parse WASM code only once for JIT #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2023
Closed
heifner
requested changes
Jul 27, 2023
heifner
requested changes
Jul 28, 2023
heifner
approved these changes
Jul 31, 2023
spoonincode
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to prevent the number of memory mappings from growing, WASM code is parsed twice.
This PR parses WASM code only once for JIT. The solution is that after the first parsing, data required by JIT execution is saved in regular C++ vectors for later use, and the memory (acquired by
mmap) used by the first parsing is released. This is made possible by #16, which moves globals out from the mmapped memory.Resolve #17
Change Description
API Changes
Documentation Additions