Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: nodeos_forked_chain_lr_test failure #2331

Closed
spoonincode opened this issue Mar 22, 2024 · 5 comments · Fixed by #2377
Closed

Test: nodeos_forked_chain_lr_test failure #2331

spoonincode opened this issue Mar 22, 2024 · 5 comments · Fixed by #2377
Labels
👍 lgtm test-instability tag issues for flaky tests, high priority to address
Milestone
Instant Finality:...

Comments

@spoonincode
Copy link
Member

https://github.com/AntelopeIO/leap/actions/runs/8392922204/job/22987149552

may or may not be related to #2243
@spoonincode spoonincode added the test-instability tag issues for flaky tests, high priority to address label Mar 22, 2024
@heifner heifner changed the title nodeos_forked_chain_lr_test failure Test: nodeos_forked_chain_lr_test failure Mar 28, 2024
@heifner
Copy link
Member

heifner commented Mar 30, 2024 •
edited
Loading

https://github.com/AntelopeIO/leap/actions/runs/8485923201/job/23251803054
https://github.com/AntelopeIO/leap/actions/runs/8490544543/job/23261873400
https://github.com/AntelopeIO/leap/actions/runs/8490544543/job/23261873400
https://github.com/AntelopeIO/leap/actions/runs/8490544543/job/23265379734 ubsan
https://github.com/AntelopeIO/leap/actions/runs/8490544543/job/23265787527 ubsan
https://github.com/AntelopeIO/leap/actions/runs/8515732035/job/23323971173 ubsan
https://github.com/AntelopeIO/leap/actions/runs/8515732035/job/23323971863 ubuntu20repo

@greg7mdp
Copy link
Contributor

greg7mdp commented Apr 2, 2024 •
edited
Loading

Most likely will be fixed by when the ci/cd instances the workflows run on are beefed up.

see #2369

Still should we investigate whether we have an issue with performance degradation caused by excessive forking in the IF branch?

@greg7mdp
Copy link
Contributor

greg7mdp commented Apr 3, 2024 •
edited
Loading

still fails consistently with new beefier instance:
https://github.com/AntelopeIO/leap/actions/runs/8544411611/job/23410864785
https://github.com/AntelopeIO/leap/actions/runs/8544411611/job/23412433997?pr=2375

@arhag arhag added 👍 lgtm and removed triage labels Apr 3, 2024
@linh2931
Copy link
Member

linh2931 commented Apr 4, 2024

https://github.com/AntelopeIO/leap/actions/runs/8548132004/job/23421654687?pr=2362#step:4:4953

@heifner
Copy link
Member

heifner commented Apr 4, 2024

https://github.com/AntelopeIO/leap/actions/runs/8548132004/job/23421654687?pr=2362#step:4:4953

Before increase in disk performance.

@heifner heifner linked a pull request Apr 4, 2024 that will close this issue
TraceAPI: Remove sync() to improve performance #2377
Merged
@heifner heifner mentioned this issue Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👍 lgtm test-instability tag issues for flaky tests, high priority to address
Projects
Team Backlog
Archived in project
Milestone
Instant Finality: Production-Ready
Development

Successfully merging a pull request may close this issue.

TraceAPI: Remove sync() to improve performance AntelopeIO/leap
6 participants
@greg7mdp @heifner @arhag @spoonincode @linh2931 @enf-ci-bot