TraceAPI: Remove sync() to improve performance #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhag
approved these changes
Apr 4, 2024
spoonincode
approved these changes
Apr 5, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been reported a few times, for example: EOSIO/eos#10690 that the
trace_api_pluginperformance suffers greatly from thesync()call in storing to disk. This has recently caused slow down in ci/cd as well causing tests to fail do to taking so long to write to the trace api log.We do not
sync()for the block log or SHiP logs. Seems the trade off of performance for small possibility of corrupted trace api logs is worth it.Resolves #2331