Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use raw Affine little-endian form of g1/g2 for encoding to BLS public key and signature #1600

Merged
merged 3 commits into from
Sep 6, 2023
Merged

use raw Affine little-endian form of g1/g2 for encoding to BLS public key and signature #1600

merged 3 commits into from
Sep 6, 2023

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Sep 6, 2023

Resolved #1596.

Use raw Affine little-endian format for BLS public key and signature.

heifner
heifner requested changes Sep 6, 2023
View reviewed changes
Copy link
Member

@heifner heifner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the from string as well (parse base64). Will also need to update tests.

@linh2931
Copy link
Member Author

linh2931 commented Sep 6, 2023

Need to update the from string as well (parse base64). Will also need to update tests.

Thanks! I forgot that. Will do.

@linh2931 linh2931 merged commit e0a9901 into hotstuff_integration Sep 6, 2023
22 checks passed
@linh2931 linh2931 deleted the pk_sig_affine_le_format branch September 6, 2023 20:24
@linh2931 linh2931 mentioned this pull request Sep 6, 2023
Closed
@arhag arhag linked an issue Sep 6, 2023 that may be closed by this pull request
Use raw Affine little-endian form of g1/g2 for encoding to BLS public key / signature #1596
Closed
@heifner heifner mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

@mschoenebeck mschoenebeck Awaiting requested review from mschoenebeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use raw Affine little-endian form of g1/g2 for encoding to BLS public key / signature
3 participants
@linh2931 @greg7mdp @heifner