IF: updated qc_chain to use bls_public_key as finalizer id, completed internal wiring for signing + verification #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal wiring for signing and signature verification
heifner
changed the title
heifner
requested changes
Sep 11, 2023
Co-authored-by: Kevin Heifner <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…ded finalizer_count parameter to quorum_certificate constructor, and resize hs_bitset to the expected size
…of the active finalizer set. Improved test to reflect expected operational conditions better
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
greg7mdp
reviewed
Sep 15, 2023
heifner
requested changes
Sep 15, 2023
| @@ -3,7 +3,7 @@ | |||
| #include <eosio/hotstuff/base_pacemaker.hpp> | |||
| #include <eosio/hotstuff/qc_chain.hpp> | |||
|
|
|||
| #include <eosio/chain/finalizer_set.hpp> | |||
| //#include <eosio/chain/finalizer_set.hpp> | |||
There was a problem hiding this comment.
This should be removed. But finalizer_set needs to be forward declared.
There was a problem hiding this comment.
I did remove the commented out line, but I'm not sure if/how the forward declaration would be used, since finalizer_set is included in the base_pacemaker.hpp header.
| static finalizer_set create_fs(std::vector<std::string> keys){ | ||
|
|
||
| std::vector<fc::crypto::blslib::bls_private_key> sks; | ||
| //std::vector<fc::crypto::blslib::bls_public_key> pks; |
greg7mdp
requested changes
Sep 20, 2023
Co-authored-by: Gregory Popovitch <[email protected]>
Co-authored-by: Gregory Popovitch <[email protected]>
greg7mdp
approved these changes
Sep 25, 2023
systemzax
force-pushed
the
internal_wiring_of_finalizers_in_qc_chain
branch
from
ac6400a
to
4ffc264
Compare
heifner
approved these changes
Sep 27, 2023
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1610 and #1626.