-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support serialization of fixed-size arrays in abi_serializer. #1918
base: main
Are you sure you want to change the base?
Conversation
I think we should check that the length of the array passed to serialize matches the size in the |
…lues. Also replace the mouthful `abi_serializer::create_yield_function( max_serialization_time )` with `yield_fn()`
I'm missing some context to this change so I may be misunderstanding what the goal is here. Fixed sized arrays have (annoyingly imo) been an omission of the ABI spec. My first thought is if cdt is generating a |
I'll let Kevin answer this one. Regardless of whether fixed-size arrays are officially supported in the abi, I don't think it would hurt to have these supported in abi_serializer. |
[partially] resolves #1931.
uint8[5]
.reserve()
when deserializing a vector (or now an array), fix unnecessary copy invector<fc::variant> vars = var.get_array();