Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] fix disabling EOS VM OC subjective limits in tests #2055

Merged
merged 1 commit into from
Jan 8, 2024
Merged

[5.0] fix disabling EOS VM OC subjective limits in tests #2055

merged 1 commit into from
Jan 8, 2024

Conversation

spoonincode
Copy link
Member

EOS VM OC's subjective limits were not actually disabled in tests as expected in #1843 due to unexpected deserialization behavior of eosio::chain::eosvmoc::config.

@spoonincode spoonincode merged commit 4bfb636 into release/5.0 Jan 8, 2024
29 checks passed
@spoonincode spoonincode deleted the fix_eosvmoc_subtests_50 branch January 8, 2024 22:13
@spoonincode spoonincode mentioned this pull request Jan 10, 2024
Merged
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Disable subjective limits in tests for greater stability during test runs.
Note:end

@spoonincode spoonincode mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spoonincode @ericpassmore @greg7mdp @heifner