IF: Fixes for IF to advance LIB #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n needed digests in block_state. Do not send out vote until after block is processed.
linh2931
reviewed
Jan 18, 2024
linh2931
reviewed
Jan 18, 2024
| return my->block_data.aggregate_vote(vote); | ||
| auto [valid, new_lib] = my->block_data.aggregate_vote(vote); | ||
| if (new_lib) { | ||
| my->if_irreversible_block_num = *new_lib; |
There was a problem hiding this comment.
Do we need to call log_irreversible here?
There was a problem hiding this comment.
We db.commit() in log_irreversible, so don't want that called from net thread.
Trying some code cleanups
greg7mdp
reviewed
Jan 18, 2024
greg7mdp
reviewed
Jan 18, 2024
greg7mdp
approved these changes
Jan 19, 2024
linh2931
approved these changes
Jan 19, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New integration test that verifies that LIB advances on all nodes under instant-finality.
Fixes for instant-finality:
net_pluginstrongserialization in vote message.fork_databaseblock_stateimplementation to usecore.last_final_block_numforirreversible_blocknum()Reviewers: Pay close attention to validation logic for
qc_info. Not sure this is the best way to handle block validation withqc_info.Works:
./tests/nodeos_lib_test.py -n 4 -p 3 -s mesh --activate-if --keep-logs -vWorks:
./tests/nodeos_lib_test.py -n 4 -p 3 -s ring --activate-if --keep-logs -vResolves #2100