IF: Support load of fork database after instant-finality is enabled #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ant-finality. GH-2083 Moved mutex out of fork database impl so it can protect transition from legacy to instant-finality.
heifner
commented
Jan 19, 2024
| * as well as switching from legacy to instant-finality. | ||
| */ | ||
| class fork_database { | ||
| mutable std::recursive_mutex m; |
There was a problem hiding this comment.
I'm not a fan of recursive mutexes. However, currently controller uses nested calls of fork_database.apply. We can look at refactoring those so that no apply calls functions which also calls apply but that will take some work.
This was
linked to
issues
Jan 19, 2024
greg7mdp
reviewed
Jan 19, 2024
greg7mdp
reviewed
Jan 20, 2024
| }}, v); | ||
| } | ||
|
|
||
| // if we every support more than one version then need to save min/max in fork_database_t |
There was a problem hiding this comment.
Comment doesn't read right. Maybe this
Suggested change
| // if we every support more than one version then need to save min/max in fork_database_t | |
| // if we ever support more than one version, then we need to save min/max in fork_database_t |
greg7mdp
approved these changes
Jan 20, 2024
linh2931
approved these changes
Jan 20, 2024
| @@ -7,6 +7,11 @@ | |||
|
|
|||
| namespace eosio::chain { | |||
|
|
|||
| // moved this warning out of header so it only uses once | |||
| #warning TDDO https://github.com/AntelopeIO/leap/issues/2080 | |||
There was a problem hiding this comment.
Now it occurs to me, if we already have an issue, we don't need a warning, because the issue will remind us.
|
Note:start |
…-persist-if-fork-db
…ap into GH-2048_whitespace
IF - addon to PR 2113 - Whitespace change to avoid very long lines.
greg7mdp
approved these changes
Jan 20, 2024
linh2931
approved these changes
Jan 20, 2024
greg7mdp
approved these changes
Jan 21, 2024
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fork_databasein legacy and after instant-finality is activated.fork_databaseto protect transition of impl from legacy to instant finality.controller::headwhich was incontroller block_data_gen_t::headtofork_database_t::chain_headblock_data_gen_tandblock_data_tResolves #2048
Resolves #2083