Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Integrate new finality core algorithm #2245

Merged
merged 24 commits into from
Feb 22, 2024
Merged

IF: Integrate new finality core algorithm #2245

merged 24 commits into from
Feb 22, 2024

Commits on Feb 20, 2024

  1. Add Areg's orginal design of new final core algorithm, written by Areg

    @linh2931
    linh2931 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ae8c0ed View commit details
    Browse the repository at this point in the history

  2. rename to finality_core.cpp

    @linh2931
    linh2931 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    03d1471 View commit details
    Browse the repository at this point in the history

  3. update finality_core

    @linh2931
    linh2931 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    1e7e5c0 View commit details
    Browse the repository at this point in the history

  4. incorporate the new finality core algorithm into Leap

    @linh2931
    linh2931 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    88cd179 View commit details
    Browse the repository at this point in the history

  5. comment out existing block_header_state_core related tests correctly

    @linh2931
    linh2931 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5f9a99d View commit details
    Browse the repository at this point in the history

  6. correct check for too old QC claims by using less than last_final_blo… 

    …ck_num()
    @linh2931
    linh2931 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b84cfad View commit details
    Browse the repository at this point in the history

  7. fix an links garbage collection issue

    @linh2931
    linh2931 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8d71a63 View commit details
    Browse the repository at this point in the history

  8. revert back the change of checking late qc claim

    @linh2931
    linh2931 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c8ebbbf View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. fixed incorrect timestamp passed in for current_block and reverted ti… 

    …mestamp assert to its correct form
    @linh2931
    linh2931 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    dfdbe67 View commit details
    Browse the repository at this point in the history

  2. adapt block_header_tests to new finality core data structures

    @linh2931
    linh2931 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a134afe View commit details
    Browse the repository at this point in the history

  3. remove block_header_state_tests.cpp as the tests there only tested ol… 

    …d block_header_state_core which has been replaced by new finality_core
    @linh2931
    linh2931 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    94e3f2c View commit details
    Browse the repository at this point in the history

  4. check in Areg's updated next function

    @linh2931
    linh2931 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    099bbd1 View commit details
    Browse the repository at this point in the history

  5. minor tweaks to get Areg's updated next function to work

    @linh2931
    linh2931 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7516e28 View commit details
    Browse the repository at this point in the history

  6. Always check next_core.refs.front after a ref block is added; use <= … 

    …operator for qc_claim comparison
    @linh2931
    linh2931 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    4544791 View commit details
    Browse the repository at this point in the history

  7. move implementation of create_core_for_genesis_block from header file… 

    … to source file; add comments to functions which did not have comments
    @linh2931
    linh2931 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    5fd3d15 View commit details
    Browse the repository at this point in the history

  8. remove unused code

    @linh2931
    linh2931 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    723a152 View commit details
    Browse the repository at this point in the history

  9. enable assert within finality_core.cpp even on CICD

    @linh2931
    linh2931 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    59bbd08 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. add new updates from Areg

    @linh2931
    linh2931 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    6291b59 View commit details
    Browse the repository at this point in the history

  2. fix minor compile errors

    @linh2931
    linh2931 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8426788 View commit details
    Browse the repository at this point in the history

  3. fix timestamp

    @linh2931
    linh2931 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    704661e View commit details
    Browse the repository at this point in the history

  4. use bb.parent.timestamp() for parent's timestamp

    @linh2931
    linh2931 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    912b0ea View commit details
    Browse the repository at this point in the history

  5. remove current_block from block_header_state_input and add parent_tim… 

    …estamp to building_block_input instead to avoid of a duplicately passing parent_id
    @linh2931
    linh2931 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d63eb49 View commit details
    Browse the repository at this point in the history

  6. use qc_claim_t for the type of qc_claim

    @linh2931
    linh2931 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4df0a26 View commit details
    Browse the repository at this point in the history

  7. change is_strong_qc constant in block_header_tests back to is_last_st… 

    …rong_qc
    @linh2931
    linh2931 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    45e7c24 View commit details
    Browse the repository at this point in the history