IF: Update fork database fork-choice rule #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead. Move current_core to block_state.
…ate, use values for fork_database by_best_branch rule.
…Only update LIB on block qc not on votes.
greg7mdp
reviewed
Feb 29, 2024
|
Nice to see the improvements. |
linh2931
reviewed
Mar 1, 2024
| uint16_t if_ext_id = instant_finality_extension::extension_id(); | ||
| assert(bsp->header_exts.count(if_ext_id) > 0); // in all instant_finality block headers | ||
| const auto& if_ext = std::get<instant_finality_extension>(bsp->header_exts.lower_bound(if_ext_id)->second); | ||
| if (if_ext.qc_claim.is_strong_qc) { |
There was a problem hiding this comment.
Add a comment here saying the claim has already been verified before.
greg7mdp
requested changes
Mar 1, 2024
libraries/chain/fork_database.cpp
Outdated
Comment on lines
546
to
553
| return my->search_on_head_branch_impl(block_num); | ||
| } | ||
|
|
||
| template<class BSP> | ||
| BSP fork_database_impl<BSP>::search_on_head_branch_impl( uint32_t block_num ) const { | ||
| for (auto i = index.find(head->id()); i != index.end(); i = index.find((*i)->previous())) { | ||
| if ((*i)->block_num() == block_num) | ||
| return *i; |
There was a problem hiding this comment.
Suggested change
| return my->search_on_head_branch_impl(block_num); | |
| } | |
| template<class BSP> | |
| BSP fork_database_impl<BSP>::search_on_head_branch_impl( uint32_t block_num ) const { | |
| for (auto i = index.find(head->id()); i != index.end(); i = index.find((*i)->previous())) { | |
| if ((*i)->block_num() == block_num) | |
| return *i; | |
| return my->search_on_branch_impl(head->id(), block_num); |
linh2931
reviewed
Mar 1, 2024
linh2931
approved these changes
Mar 1, 2024
greg7mdp
approved these changes
Mar 1, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR, we no longer update LIB via votes. LIB is only updated according to qc claims in block extensions.
Update
fork_databasefork-choice rule.Computed fields for index (in order):
Potentially switches forks before starting to produce a block. Does not interrupt producing blocks once block production has started.
Includes some misc performance improvements to
fork_database.Currently does not include voting on non-validated blocks. Would like to add the voting change in #2159 or as a separate PR.
Resolves #2125