Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] avoid using a stack variable after return #2309

Merged
merged 2 commits into from
Mar 23, 2024
Merged

[5.0] avoid using a stack variable after return #2309

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
484115e
fix usage of stack variable after return
spoonincode Mar 13, 2024
d80b143
explicit capture list
spoonincode Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/producer_api_plugin/producer_api_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ using namespace eosio;
#define CALL_WITH_400(api_name, category, api_handle, call_name, INVOKE, http_response_code) \
{std::string("/v1/" #api_name "/" #call_name), \
api_category::category, \
[&](string&&, string&& body, url_response_callback&& cb) mutable { \
[&http, &producer](string&&, string&& body, url_response_callback&& cb) mutable { \
try { \
INVOKE \
cb(http_response_code, fc::variant(result)); \
Expand Down Expand Up @@ -63,6 +63,7 @@ using namespace eosio;
auto result = api_handle.call_name(std::move(params));

#define INVOKE_R_R_D(api_handle, call_name, in_param) \
const fc::microseconds http_max_response_time = http.get_max_response_time(); \
auto deadline = http_max_response_time == fc::microseconds::maximum() ? fc::time_point::maximum() \
: fc::time_point::now() + http_max_response_time; \
auto params = parse_params<in_param, http_params_types::possible_no_params>(body);\
Expand Down Expand Up @@ -91,7 +92,6 @@ void producer_api_plugin::plugin_startup() {
// lifetime of plugin is lifetime of application
auto& producer = app().get_plugin<producer_plugin>();
auto& http = app().get_plugin<http_plugin>();
fc::microseconds http_max_response_time = http.get_max_response_time();

app().get_plugin<http_plugin>().add_api({
CALL_WITH_400(producer, producer_ro, producer, paused,
Expand Down
Loading