Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Create a new action receipt digest for Savanna blocks and move the digest computation to action_trace #2326

Merged
merged 13 commits into from
Mar 25, 2024
Merged

IF: Create a new action receipt digest for Savanna blocks and move the digest computation to action_trace #2326

merged 13 commits into from
Mar 25, 2024

Conversation

greg7mdp
Copy link
Contributor

Resolves #2161.

This PR:

  • renames action_receipt::digest() to action_trace::digest_legacy()
  • adds a new action_trace::digest_savanna()
  • updates the existing calling places to use action_trace::digest_legacy()

When PR #2316 is merged, we will need to:

  1. use the correct digest computation depending on Savanna/Legacy blocks.
  2. store in Legacy blocks validated during the transtion pre-computed Savanna digests
  3. use these Savanna digests for the conversion block_state_legacy -> block_state during the transition, so that the savanna merkle trees are computed correctly.

@greg7mdp greg7mdp linked an issue Mar 19, 2024 that may be closed by this pull request
IF: Modify the action_receipt digest to be computed by concatenating and hashing a pair constructed from act_digest and the rest of the values of the action_receipt #2161
Closed
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Create a new action receipt digest for Savanna blocks.
Note:end

@greg7mdp greg7mdp merged commit 1b0a63b into hotstuff_integration Mar 25, 2024
34 checks passed
@greg7mdp greg7mdp deleted the gh_2161 branch March 25, 2024 15:23
@arhag arhag mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@greg7mdp @ericpassmore @heifner @linh2931