IF: Support irreversible read-mode under Savanna #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
reviewed
Mar 25, 2024
libraries/chain/controller.cpp
Outdated
| fork_db.switch_to_legacy(); // apply block uses to know what types to create | ||
| fc::scoped_exit<std::function<void()>> e([&]{fork_db.switch_to_both();}); | ||
| apply_block(br, legacy, controller::block_status::complete, trx_meta_cache_lookup{}); | ||
| // irreversible apply was just done, calculate new_valid here instead of in transition_to_savanna() |
There was a problem hiding this comment.
Is it possible to create valid in one place in transition_to_savanna()?
There was a problem hiding this comment.
Factored out into a function.
|
Note:start |
greg7mdp
reviewed
Mar 26, 2024
greg7mdp
approved these changes
Mar 26, 2024
linh2931
approved these changes
Mar 28, 2024
This was referenced Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for transition to savanna running with
read-mode = irreversible.Resolves #2286