IF: Change bls_public_key & bls_signature serialization #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignature to be affine non-montgomery little-endian
heifner
changed the title
Base automatically changed from
ship_finality_info_support
to
hotstuff_integration
March 27, 2024 13:29
greg7mdp
reviewed
Mar 27, 2024
|
Note:start |
greg7mdp
approved these changes
Mar 27, 2024
…ernal tools like EOSJS
linh2931
reviewed
Mar 28, 2024
greg7mdp
reviewed
Mar 28, 2024
| friend T& operator<<(T& ds, const bls_public_key& sig) { | ||
| // Serialization as variable length array when it is stored as a fixed length array. This makes for easier deserialization by external tools | ||
| fc::raw::pack(ds, fc::unsigned_int(static_cast<uint32_t>(sig._affine_non_montgomery_le.size()*sizeof(uint8_t)))); | ||
| ds.write(reinterpret_cast<const char*>(sig._affine_non_montgomery_le.data()), sig._affine_non_montgomery_le.size()*sizeof(uint8_t)); |
There was a problem hiding this comment.
why not?
Suggested change
| ds.write(reinterpret_cast<const char*>(sig._affine_non_montgomery_le.data()), sig._affine_non_montgomery_le.size()*sizeof(uint8_t)); | |
| ds.write(reinterpret_cast<const char*>(sig._affine_non_montgomery_le.data()), sizeof(sig._affine_non_montgomery_le)); | |
linh2931
approved these changes
Mar 28, 2024
greg7mdp
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
bls_public_keyandbls_signatureserialization to be:Add
bls_aggregate_signaturewhich is mutable version ofbls_signature.bls_signatureis now immutable.Serialize as variable sized array and instead of a fixed sized array to make it easier to use in external tools that use ABI since our ABI does not handle fixed sized arrays.
Resolves #2334