Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] fix some minor misspellings #2398

Merged
merged 1 commit into from
Aug 8, 2024
Merged

[5.0] fix some minor misspellings #2398

merged 1 commit into from
Aug 8, 2024

Conversation

spoonincode
Copy link
Member

Resolves #2396

@spoonincode spoonincode linked an issue Jul 26, 2024 that may be closed by this pull request
Typo (glock -> block) in description of get_block_header_state in the chain API plugin yaml #2396
Closed
heifner
heifner approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the point of backporting this.

@spoonincode
Copy link
Member Author

The glock/block mixup actually makes its way to the public doc website which certainly warrants that one being fixed imo
https://docs.eosnetwork.com/apis/leap/latest/chain.api/#operation/get_block_header_state

@spoonincode spoonincode merged commit 0242caa into release/5.0 Aug 8, 2024
29 checks passed
@spoonincode spoonincode deleted the spelling_50 branch August 8, 2024 16:01
@spoonincode
Copy link
Member Author

I don't see the point of backporting this.

oh yeah that description was entirely changed in spring anyways. oh well

@spoonincode spoonincode mentioned this pull request Aug 8, 2024
Merged
@ericpassmore
Copy link
Contributor

Note:start
category: Chores
component: Internal
summary: Fix minor misspellings.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo (glock -> block) in description of get_block_header_state in the chain API plugin yaml
5 participants
@spoonincode @ericpassmore @greg7mdp @heifner @linh2931