Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.3] P2P: Resolve on reconnect #2410

Closed
wants to merge 6 commits into from
Closed

[5.0.3] P2P: Resolve on reconnect #2410

wants to merge 6 commits into from

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 2, 2024

Resolve address on reconnect. (Take 2, See #2408)

Instead of:

info  2024-09-25T21:50:50.686 net-1     net_plugin.cpp:2797           operator()           ] connection failed to p2p.telos-bad.zenblocks.io:9876, Element not found
info  2024-09-25T21:50:50.686 net-1     net_plugin.cpp:1461           _close               ] ["p2p.telos-bad.zenblocks.io:9876" - 1 <unknown>:<unknown>] closing

Now you get:

warn  2024-09-25T21:42:48.642 net-0     net_plugin.cpp:4524           operator()           ] Unable to resolve p2p.telos-bad.zenblocks.io:9876 Host not found (authoritative)

This takes a different approach than #2408. This approach is closer to Leap 4.0 approach to connection lifetime although it does keep the connections_manager added in Leap 5.0.

Backport of AntelopeIO/spring#853

@ericpassmore ericpassmore added the bug Something isn't working label Oct 2, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: P2P
summary: When reconnecting using the net plugin resolve endpoint.
Note:end

@ericpassmore ericpassmore self-requested a review October 2, 2024 14:22
@heifner heifner marked this pull request as draft October 2, 2024 17:00
@heifner
Copy link
Member Author

heifner commented Oct 11, 2024

Not backporting fix.

@heifner heifner closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants