P2P: Check for is_quitting() for faster shutdown #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Oct 18, 2024
linh2931
reviewed
Oct 18, 2024
| @@ -3694,6 +3694,8 @@ namespace eosio { | |||
| // post to dispatcher strand so that we don't have multiple threads validating the block header | |||
| peer_dlog(this, "posting block ${n} to dispatcher strand", ("n", ptr->block_num())); | |||
| my_impl->dispatcher.strand.post([id, c{shared_from_this()}, ptr{std::move(ptr)}, cid=connection_id]() mutable { | |||
| if (app().is_quiting()) // large sync span can have many of these queued up, exit quickly | |||
There was a problem hiding this comment.
Why not check this before post?
There was a problem hiding this comment.
The only thing that happens before the post is pulling the block off the wire. The expensive part is done inside this post. So this implicit queue can become large. The check needs to be inside since that is what is queued up.
linh2931
approved these changes
Oct 18, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large
sync-fetch-span, shutdown can be slow as there can be many queued up blocks to process on the dispatcher strand. Check forapp().is_quitting()for faster shutdown. This provides a noticable improvement in response to ctrl-c shutdown request.Related to #922