Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper usage of debug_traceTransaction [APE-1195] #57

Merged
merged 7 commits into from
Sep 1, 2023

Conversation

antazoey
Copy link
Member

What I did

The normal structlog tracer is actually not supported in Alchemy, not sure how that gone unnoticed.
But they do support the call tracer tracer, but that just makes call tree nodes really...

How I did it

  • Remove API method we cannot support
  • Utilize callTracer approach as a backup when Parity style fails (not sure if that actually ever happens tho)

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title fix: proper usage of debug_traceTransaction fix: proper usage of debug_traceTransaction [APE-1195] Jul 17, 2023
@antazoey
Copy link
Member Author

antazoey commented Sep 1, 2023

Screenshot 2023-09-01 at 09 27 30 tests fail in ci because it is from a fork, but all is well

fubuloubu
fubuloubu previously approved these changes Sep 1, 2023
@antazoey antazoey merged commit 9ba4a32 into ApeWorX:main Sep 1, 2023
6 of 14 checks passed
@antazoey antazoey deleted the fix/debug-tt branch September 1, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants