Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type 2 fixes and custom network fixes #9

Merged
merged 3 commits into from
Jan 23, 2024
Merged

fix: type 2 fixes and custom network fixes #9

merged 3 commits into from
Jan 23, 2024

Conversation

antazoey
Copy link
Member

What I did

issues with type 2 creation
issues with custom network

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

fubuloubu
fubuloubu approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this inherit from optimism now?

@antazoey
Copy link
Member Author

Could this inherit from optimism now?

yes, but still have to do custom things it seems.

  1. Base has defined a transaction type not present in Optimism
  2. Base still used Type 0 transactions instead of type 2, like Optimism

@antazoey antazoey merged commit ec6837b into ApeWorX:main Jan 23, 2024
13 checks passed
@antazoey antazoey deleted the refactor/cfg branch January 23, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @fubuloubu