Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Handle 0.7 breaking changes and updates [APE-1553] #20

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

NotPeopling2day
Copy link
Contributor

What I did

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title feat!: update versions feat!: update versions [APE-1553] Nov 22, 2023
@antazoey
Copy link
Member

In init.py, I am thinking we change:

from ape_geth import GethProvider

to

from ape_ethereum.provider import EthereumNodeProvider

Can you check if that works?

@antazoey
Copy link
Member

this line: https://github.com/ApeWorX/ape-bsc/blob/main/tests/test_ecosystem.py#L22

parse_obj is deprecated, change it to model_validate() pleaseee

antazoey
antazoey previously approved these changes Dec 12, 2023
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotPeopling2day NotPeopling2day changed the title feat!: update versions [APE-1553] feat!: Handle 0.7 breaking changes and updates [APE-1553] Dec 18, 2023
@NotPeopling2day NotPeopling2day enabled auto-merge (squash) December 19, 2023 00:24
@NotPeopling2day NotPeopling2day merged commit 90a95f4 into ApeWorX:main Dec 19, 2023
12 checks passed
@NotPeopling2day NotPeopling2day deleted the feature/ape-1543 branch December 19, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants