Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue detecting proper message from certain virtual machine errors #111

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

antazoey
Copy link
Member

What I did

fixes: #97
This fixes what went wrong but i am not sure about the actual problem enough to know how to test this OR ensure everything else work

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey changed the title fix: force str when handling VM errors fix: issue detecting proper message from certain virtual machine errors Jul 26, 2024
@antazoey antazoey requested a review from fubuloubu July 26, 2024 18:38
@antazoey antazoey merged commit 1a09913 into ApeWorX:main Jul 26, 2024
13 checks passed
@antazoey antazoey deleted the fix/ensure-str branch July 26, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'MaxRetryError' object has no attribute 'startswith'
2 participants