Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: utilize core feature for impersonating accounts and sending txns #113

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Aug 1, 2024

What I did

mostly getting to delete code because of this work here: ApeWorX/ape#2195

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey changed the title refactor: utilize core feature of impersonating accounts refactor: utilize core feature for impersonating accounts and sending txns Aug 5, 2024
@antazoey antazoey marked this pull request as ready for review August 5, 2024 22:52
try:
enriched.txn.receipt.show_trace()
except Exception:
# TODO: Fix this in Ape
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically empty reverts from foundry and causing problem in Ape, nothing really broken in the plugin but i have to fix this in ape

@antazoey antazoey merged commit e7c7aae into ApeWorX:main Aug 7, 2024
13 checks passed
@antazoey antazoey deleted the perf/impersonate-accounts branch August 7, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant