Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete unneeded try / except blocks for erroring revert checks on emptiness #114

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix: delete unneeded try / except blocks for erroring revert checks on emptiness #114

merged 2 commits into from
Aug 15, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Aug 7, 2024

What I did

can delete hacky fix after ApeWorX/ape#2210 merges and releases

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey requested a review from dtdang August 7, 2024 23:33
dtdang
dtdang previously approved these changes Aug 8, 2024
View reviewed changes
@antazoey antazoey merged commit f4f8332 into ApeWorX:main Aug 15, 2024
13 checks passed
@antazoey antazoey deleted the fix/undo-unneeded-try branch August 15, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtdang dtdang dtdang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @dtdang