Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize getting virtual machine errors #115

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

antazoey
Copy link
Member

What I did

Before:

Wall time: 554 ms

Then with ApeWorX/ape#2211

Wall time: 450 ms

Then with this PR and not ApeWorX/ape#2211

Wall time: 273 ms

Then with this PR AND ApeWorX/ape#2211

Wall time: 245 ms

How I did it

I think the main thing was not defining such a large method within another method
but also some condition combines probably helped.

How to verify it

should work like it did before

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey marked this pull request as ready for review August 16, 2024 13:38
@antazoey
Copy link
Member Author

Interesting

Screenshot 2024-08-16 at 08 39 09

@antazoey antazoey merged commit f04c451 into ApeWorX:main Aug 20, 2024
13 checks passed
@antazoey antazoey deleted the perf/get-vm-err branch August 20, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants