Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: base fee fix for remote host [APE-1196] #64

Merged
merged 2 commits into from
Jul 18, 2023
Merged

fix: base fee fix for remote host [APE-1196] #64

merged 2 commits into from
Jul 18, 2023

Conversation

antazoey
Copy link
Member

What I did

issue preventing base fee from being correct when connecting to a remote host

How I did it

remove "perf"

How to verify it

send txns on remote host and notice base fee is no longer 0 when it makes sense

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title fix: base fee fix for remote host fix: base fee fix for remote host [APE-1196] Jul 17, 2023
@antazoey
Copy link
Member Author

tests failing because of #65

@antazoey antazoey enabled auto-merge (squash) July 18, 2023 17:28
@antazoey antazoey merged commit 77e291f into ApeWorX:main Jul 18, 2023
13 checks passed
@antazoey antazoey deleted the fix/base-fee branch July 18, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabotagebeats sabotagebeats sabotagebeats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @sabotagebeats