feat: add http_uri and ws_uri [APE-1447] #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
APE-1447 "feat: add http_uri and ws_uri" (ApeWorX/ape-foundry #73)
What I didfixes: # How I did itHow to verify itChecklist
ApeWorX/ape-foundry #73 by fubuloubu on GitHub via LinearSync |
antazoey
previously approved these changes
Oct 10, 2023
antazoey
reviewed
Oct 10, 2023
| return self.uri | ||
|
|
||
| @property | ||
| def ws_uri(self) -> str: |
There was a problem hiding this comment.
is this URL correct? I can't seem to connect it or see anything I need to do to enable WS
There was a problem hiding this comment.
seems to work for me 🤷
antazoey
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #
How I did it
How to verify it
Checklist