Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show call trace on transaction revert #92

Merged
merged 3 commits into from
Mar 8, 2024
Merged

feat: show call trace on transaction revert #92

merged 3 commits into from
Mar 8, 2024

Conversation

mikeshultz
Copy link
Member

What I did

Will show the call trace on transaction revert.

Ref: ApeWorX/ape#1945

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@mikeshultz mikeshultz added the category: feature New feature or request label Mar 6, 2024
@mikeshultz mikeshultz self-assigned this Mar 6, 2024
@mikeshultz
Copy link
Member Author

Test failure appears to be on main and CI only. Submitted a report: #94. Test passes locally for me. Can take a look at it tomorrow.

@mikeshultz mikeshultz mentioned this pull request Mar 6, 2024
Closed
@mikeshultz mikeshultz marked this pull request as ready for review March 8, 2024 01:19
@mikeshultz mikeshultz requested a review from antazoey March 8, 2024 01:19
@mikeshultz mikeshultz merged commit e90b82c into main Mar 8, 2024
24 checks passed
@mikeshultz mikeshultz deleted the feat/trace branch March 8, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antazoey antazoey antazoey approved these changes

Assignees

@mikeshultz mikeshultz

Labels
category: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeshultz @antazoey