Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue where mistakenly said EthTester can handle fork networks [APE-1392] #21

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

antazoey
Copy link
Member

What I did

it showed:

├── mainnet-fork
│   ├── foundry
│   ├── ganache
│   ├── hardhat
|   └── test (default)

even though that is not true.
so i realized someone (prolly me) mistakenly put the fork part in the providers instead of the networks but it was in both

How I did it

remove it from providers.
basically, copy all the other L2 plugins. this was the only one that was bad.

How to verify it

ape networks list --ecosystem polygon

all the fork networks should not have test as a provider.

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title fix: issue where mistakenly said EthTester can handle fork networks fix: issue where mistakenly said EthTester can handle fork networks [APE-1392] Sep 14, 2023
@antazoey antazoey requested a review from dtdang October 4, 2023 21:45
dtdang
dtdang previously approved these changes Oct 4, 2023
@antazoey antazoey enabled auto-merge (squash) October 4, 2023 22:02
@antazoey antazoey disabled auto-merge October 4, 2023 22:02
@antazoey antazoey merged commit 855fafc into ApeWorX:main Oct 4, 2023
11 checks passed
@antazoey antazoey deleted the fix/rm-bad-fork-providers branch October 4, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants