Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various issues with propose cli #24

Merged
merged 3 commits into from
Dec 22, 2023
Merged

fix: various issues with propose cli #24

merged 3 commits into from
Dec 22, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Dec 22, 2023 •
edited
Loading

What I did

  • fix: issue with propose execution, sender is required for initial proposal but doesnt mean we want to execute
  • gas price was not settable
  • account state was lost - i think only really matter with MockClient - but fixed
  • missing success log when proposing
  • filled in some tests surrounding the propose command but benefits i think all command
  • handle some 0.7.1 upgrades

coing up next, ill look at approve, add tests, and fill in any gaps there.

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey force-pushed the fix/issues-with-propose branch 2 times, most recently from d5a5868 to ea6fdf6 Compare December 22, 2023 15:45
fubuloubu
fubuloubu approved these changes Dec 22, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
ape_safe/accounts.py Outdated Show resolved Hide resolved
@antazoey antazoey merged commit 58fd348 into ApeWorX:main Dec 22, 2023
13 checks passed
@antazoey antazoey deleted the fix/issues-with-propose branch December 22, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

@NotPeopling2day NotPeopling2day Awaiting requested review from NotPeopling2day

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @fubuloubu