fix: issue where revert infos were the same [APE-1210] (#1550)

src/ape/pytest/contextmanagers.py

@@ -32,7 +32,7 @@ def __init__(
         self.expected_message = expected_message
         self.dev_message = dev_message
         self.error_inputs = error_inputs
-        self.revert_info = RevertInfo()
+        self.revert_info: Optional[RevertInfo] = None
 
     def _check_dev_message(self, exception: ContractLogicError):
         """
@@ -142,7 +142,9 @@ def _check_custom_error(self, exception: Union[CustomError]):
             raise AssertionError("\n".join(incorrect_values))
 
     def __enter__(self, *args, **kwargs):
-        return self.revert_info
+        info = RevertInfo()
+        self.revert_info = info
+        return info
 
     def __exit__(self, exc_type: Type, exc_value: Exception, traceback) -> bool:
         if exc_type is None:
@@ -166,7 +168,8 @@ def __exit__(self, exc_type: Type, exc_value: Exception, traceback) -> bool:
 
         # Set the exception on the returned info.
         # This allows the user to make further assertions on the exception.
-        self.revert_info.value = exc_value
+        if self.revert_info is not None:
+            self.revert_info.value = exc_value
 
         # Returning True causes the expected exception not to get raised
         # and the test to pass

tests/functional/test_reverts_context_manager.py

@@ -6,6 +6,20 @@
 from tests.conftest import geth_process_test
 
 
+def test_revert_info_context(owner, reverts_contract_instance):
+    """
+    Shows no two revert info objects are the same instance.
+    """
+
+    rev = reverts()
+    with rev as rev0:
+        reverts_contract_instance.revertStrings(0, sender=owner)
+    with rev as rev1:
+        reverts_contract_instance.revertStrings(1, sender=owner)
+
+    assert rev0.value.revert_message != rev1.value.revert_message
+
+
 def test_no_args(owner, reverts_contract_instance):
     """
     Test catching transaction reverts without asserting on error messages.