-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue when switching providers when disconnecting [APE-1460] #1700
Conversation
im still working something out in foundry..
|
update: making progress on this but haven't completed or am ready to push yet but hoping to have something cleaned up soon. Apologies for the delay! |
b51c7b1
to
1944e07
Compare
Somehow it works with hardhat but I think some more updates are needed there anyway. |
86b152a
to
4948c42
Compare
checked this out in working with https://github.com/ApeWorX/silverback/tree/feat/add-backtesting seems to work! |
Co-authored-by: NotPeopling2day <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies about the formatting on the suggestion :/
What I did
fixed bug with Disconnect => reconnect with new settings was bugged when using the same Python session.
also adds
settings
object which is useful for getting all provider settings mashed together.Also, fixes an issue where settings were not updated when connecting to an already-connected provider with new settings.
note: as I was fixing this, I had some random failing tests pop up; bugs highlighted with the networks yaml not actually filtering. I had to fix this in order to get a passing build on this PR.
That caused this PR to be a little out of scope but I don't think it is worth opening more PRs at this point; it is all network related anyway.
How I did it
Delete provider from connected providers when disconnecting
How to verify it
in combo with
ApeWorX/ape-foundry#74
you can do:
You can even switch multiple times to have many ongoing foundrys:
Outputs:
Checklist