Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: drop 3.8 support #1983

Merged
merged 15 commits into from
Apr 20, 2024
Merged

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Apr 2, 2024

What I did

requires:

ApeWorX/eip712#44
ApeWorX/evm-trace#59
ApeWorX/ethpm-types#118
ApeWorX/eth-pydantic-types#7

ApeWorX/evmchains#7

fixes: #

note: changes from running pyupgrade --py39-plus

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

fubuloubu
fubuloubu previously approved these changes Apr 9, 2024
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with dropping 3.8 for Ape v0.8

For now, if the move to add official 3.12 support can be added to downstream ApeWorX packages firs, and then to Ape within 0.7.x series, they can be accomplished non-breaking

setup.py Outdated Show resolved Hide resolved
@fubuloubu
Copy link
Member

fubuloubu commented Apr 12, 2024

I also think some of our processes were using 3.8 since as type checking, linting, and docs

They can maybe upgrade to 3.9 or 3.11 (not sure which is better)

@NotPeopling2day NotPeopling2day changed the base branch from main to feat/08 April 16, 2024 01:09
@antazoey antazoey force-pushed the feat/08 branch 2 times, most recently from f2a565c to 56a0013 Compare April 17, 2024 20:37
@antazoey
Copy link
Member Author

antazoey commented Apr 18, 2024

Processes are all using 3.10 as far as I can tell, I don't know what is best either.
Edit: on separate PR, we can change those to be '3.x' so it uses the latest.

setup.py Show resolved Hide resolved
@banteg
Copy link
Contributor

banteg commented Apr 19, 2024

i've been devving on 3.12 and haven't seen any issues.

i'm pro dropping 3.9 too, dropping just 3.8 doesn't offer much interesting features.

installing any python version is trivial nowadays with pyenv or rye, and it's not like ape is used in any embedded systems where you can't upgrade.

@antazoey
Copy link
Member Author

i've been devving on 3.12 and haven't seen any issues.

the main issue on 3.12 right now (which is soon to be fixed) is that there are some Ethereum packages importing from pkg_resources which may not be installed. We are soon to having this fully fixed, there is a separate PR for it.

i'm pro dropping 3.9 too, dropping just 3.8 doesn't offer much interesting features.

We are trying to wait closer to EOL for 3.9. There is actually a nice 3.8drop affordance we gained - typing improvements. No longer are we cursed to importing List, Dict, we can finally use list[str] style syntax for typing

@NotPeopling2day
Copy link
Contributor

@antazoey I tried to resolve the merge conflicts but please double check!

@NotPeopling2day NotPeopling2day merged commit a71d039 into ApeWorX:feat/08 Apr 20, 2024
11 checks passed
antazoey added a commit that referenced this pull request Apr 20, 2024
@antazoey antazoey deleted the refactor/py38drop branch April 20, 2024 14:29
antazoey added a commit that referenced this pull request Apr 22, 2024
antazoey added a commit to banteg/ape that referenced this pull request Apr 22, 2024
antazoey added a commit to banteg/ape that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants