Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ws_uri config to ape-node #2194

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Conversation

antazoey
Copy link
Member

What I did

allows users to configure a ws_uri in their node config (per network, same as uri).

How I did it

implement a custom ws_uri in

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

fubuloubu
fubuloubu previously approved these changes Jul 31, 2024
fubuloubu
fubuloubu previously approved these changes Aug 1, 2024
docs/userguides/networks.md Show resolved Hide resolved
fubuloubu
fubuloubu previously approved these changes Aug 2, 2024
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really exciting, but when we migrate the subscriptions manager code upstream, we can actually use IPC Providers as well for silverback automatically

docs/userguides/networks.md Outdated Show resolved Hide resolved
@antazoey antazoey merged commit 5021474 into ApeWorX:main Aug 2, 2024
15 checks passed
@antazoey antazoey deleted the feat/ws-config branch August 2, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants