Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bypass balance check impersonated accounts #2209

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Aug 7, 2024

What I did

Let's not check balance for impersonated accounts, as some providers (with the right settings) will allow it to work regardless. In any case, the VM error may be better anyway.

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey changed the title fix: bypass balance check imp accounts fix: bypass balance check impersonated accounts Aug 7, 2024
@antazoey antazoey force-pushed the fix/impersonated-acct-bypass branch from 55031e1 to 6d184d2 Compare August 7, 2024 14:40
@antazoey antazoey marked this pull request as ready for review August 8, 2024 18:21
@antazoey antazoey merged commit bce0c18 into ApeWorX:main Aug 12, 2024
15 checks passed
@antazoey antazoey deleted the fix/impersonated-acct-bypass branch August 12, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants