-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adds exception check for debug_setHead #2217
Merged
antazoey
merged 17 commits into
ApeWorX:main
from
bitwise-constructs:fix/debug-set-head-fail
Aug 14, 2024
Merged
fix: adds exception check for debug_setHead #2217
antazoey
merged 17 commits into
ApeWorX:main
from
bitwise-constructs:fix/debug-set-head-fail
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat don't support it
fubuloubu
reviewed
Aug 13, 2024
antazoey
reviewed
Aug 13, 2024
…hat don't support it
antazoey
force-pushed
the
fix/debug-set-head-fail
branch
from
August 14, 2024 20:51
fe9197d
to
506cda8
Compare
…ts/ape into fix/debug-set-head-fail
antazoey
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
adds exception check for debug_setHead when dealing with nodes that don't support it
fixes: #2215
Fixes: APE-1797
How I did it
added a cached property to provider for skipping debug_setHead restore if not supported
How to verify it
run on a forked gnosis chain
Checklist