feat: add info logger to display connection status and chain ID #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im writing the test atm |
antazoey
reviewed
Sep 5, 2024
| @@ -1075,7 +1089,12 @@ def start(self, timeout: int = 20): | |||
| with RPCTimeoutError(self, seconds=timeout) as _timeout: | |||
| while True: | |||
| if self.is_connected: | |||
| break | |||
| chain_id = self.chain_id # Ensure this is how chain_id is accessed | |||
| if chain_id == 1337: | |||
There was a problem hiding this comment.
The chain ID is configurable and does not mean it is an Ethereum tester node. Any node can use this port!
fubuloubu
reviewed
Sep 5, 2024
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
|
This PR was closed because it has been inactive for 35 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
Modify the start method in the provider to include additional logging.
after confirming the provider is connected, the method checks the chain_id. If the chain_id is 1337, it logs a message indicating a connection to a local test chain.
How to verify it
Checklist